[Merged by Bors] - Ensure protoc is installed for release CI#3621
Closed
michaelsproul wants to merge 5 commits intosigp:unstablefrom
Closed
[Merged by Bors] - Ensure protoc is installed for release CI#3621michaelsproul wants to merge 5 commits intosigp:unstablefrom
michaelsproul wants to merge 5 commits intosigp:unstablefrom
Conversation
michaelsproul
force-pushed
the
protoc-for-release
branch
from
40165e7 to
d5027e7
Compare
michaelsproul
changed the title
michaelsproul
changed the title
michaelsproul
added
ready-for-review
Member
Author
|
This is ready for review. Here's a run mostly working on my fork:
|
michaelsproul
added
work-in-progress
Member
Author
|
Actually, |
michaelsproul
added
ready-for-review
Member
Author
michaelsproul
added
the
low-hanging-fruit
paulhauner
approved these changes
Oct 3, 2022
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Nice! The simplification of cross Dockerfiles is tidy
michaelsproul
added
ready-for-merge
Member
Author
|
Thanks! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
## Issue Addressed The release CI is currently broken due to the addition of the `protoc` dependency. Here's a failure of the release flow running on my fork: https://github.com/michaelsproul/lighthouse/actions/runs/3155541478/jobs/5134317334 ## Proposed Changes - Install `protoc` on Windows and Mac so that it's available for `cargo install`. - Install an x86_64 binary in the Cross image for the aarch64 platform: we need a binary that runs on the host, _not_ on the target. - Fix `macos` local testnet CI by using the Github API key to dodge rate limiting (this issue: actions/runner-images#602).
bors
bot
changed the title
This was referenced Nov 9, 2022
bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2022
## Issue Addressed Closes #3656 ## Proposed Changes * Replace `set-output` by `$GITHUB_OUTPUT` usage * Avoid rate-limits when installing `protoc` by making authenticated requests (continuation of #3621) * Upgrade all Ubuntu 18.04 usage to 22.04 (18.04 is end of life) * Upgrade macOS-latest to explicit macOS-12 to silence warning * Use `actions/checkout@v3` and `actions/cache@v3` to avoid deprecated NodeJS v12 ## Additional Info Can't silence the NodeJS warnings entirely due to #3705. Can fix that in future.
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
## Issue Addressed Closes sigp#3656 ## Proposed Changes * Replace `set-output` by `$GITHUB_OUTPUT` usage * Avoid rate-limits when installing `protoc` by making authenticated requests (continuation of sigp#3621) * Upgrade all Ubuntu 18.04 usage to 22.04 (18.04 is end of life) * Upgrade macOS-latest to explicit macOS-12 to silence warning * Use `actions/checkout@v3` and `actions/cache@v3` to avoid deprecated NodeJS v12 ## Additional Info Can't silence the NodeJS warnings entirely due to sigp#3705. Can fix that in future.
divagant-martian
added a commit
to divagant-martian/lighthouse
that referenced
this pull request
Mar 14, 2023
This reverts commit 58bd2f7.
divagant-martian
added a commit
to divagant-martian/lighthouse
that referenced
this pull request
Apr 13, 2023
This reverts commit 58bd2f7.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed The release CI is currently broken due to the addition of the `protoc` dependency. Here's a failure of the release flow running on my fork: https://github.com/michaelsproul/lighthouse/actions/runs/3155541478/jobs/5134317334 ## Proposed Changes - Install `protoc` on Windows and Mac so that it's available for `cargo install`. - Install an x86_64 binary in the Cross image for the aarch64 platform: we need a binary that runs on the host, _not_ on the target. - Fix `macos` local testnet CI by using the Github API key to dodge rate limiting (this issue: actions/runner-images#602).
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed Closes sigp#3656 ## Proposed Changes * Replace `set-output` by `$GITHUB_OUTPUT` usage * Avoid rate-limits when installing `protoc` by making authenticated requests (continuation of sigp#3621) * Upgrade all Ubuntu 18.04 usage to 22.04 (18.04 is end of life) * Upgrade macOS-latest to explicit macOS-12 to silence warning * Use `actions/checkout@v3` and `actions/cache@v3` to avoid deprecated NodeJS v12 ## Additional Info Can't silence the NodeJS warnings entirely due to sigp#3705. Can fix that in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
The release CI is currently broken due to the addition of the
protocdependency. Here's a failure of the release flow running on my fork: https://github.com/michaelsproul/lighthouse/actions/runs/3155541478/jobs/5134317334Proposed Changes
protocon Windows and Mac so that it's available forcargo install.macoslocal testnet CI by using the Github API key to dodge rate limiting (this issue: API rate limit exceeded for Mac OS hosted by GitHub itself actions/runner-images#602).